fix(#190): hide uninstall option if app is system app. (#198)

Co-authored-by: Joshua Kuestersteffen <jkuester@kuester7.com>

app/src/main/java/com/sduduzog/slimlauncher/ui/main/HomeFragment.kt

@@ -46,6 +46,7 @@ import com.sduduzog.slimlauncher.models.MainViewModel
 import com.sduduzog.slimlauncher.ui.dialogs.RenameAppDisplayNameDialog
 import com.sduduzog.slimlauncher.utils.BaseFragment
 import com.sduduzog.slimlauncher.utils.OnLaunchAppListener
+import com.sduduzog.slimlauncher.utils.isSystemApp
 import dagger.hilt.android.AndroidEntryPoint
 import kotlinx.android.synthetic.main.home_fragment_content.app_drawer_edit_text
 import kotlinx.android.synthetic.main.home_fragment_content.app_drawer_fragment_list
@@ -377,6 +378,7 @@ class HomeFragment : BaseFragment(), OnLaunchAppListener {
         fun onAppLongClicked(app : UnlauncherApp, view: View) : Boolean {
             val popupMenu = PopupMenu(context, view)
             popupMenu.inflate(R.menu.app_long_press_menu)
+            hideUninstallOptionIfSystemApp(app, popupMenu)
 
             popupMenu.setOnMenuItemClickListener { item: MenuItem? ->
 
@@ -401,8 +403,6 @@ class HomeFragment : BaseFragment(), OnLaunchAppListener {
                         val intent = Intent(Intent.ACTION_DELETE)
                         intent.data = Uri.parse("package:" + app.packageName)
                         uninstallAppLauncher.launch(intent)
-                        //appDrawerAdapter.notifyDataSetChanged()
-                        // TODO: Handle the case when this is done for system apps
                     }
                 }
                 true
@@ -419,6 +419,15 @@ class HomeFragment : BaseFragment(), OnLaunchAppListener {
             return true
         }
 
+        private fun hideUninstallOptionIfSystemApp(app:UnlauncherApp, popupMenu: PopupMenu) {
+            val pm = requireContext().packageManager
+            val info = pm.getApplicationInfo(app.packageName, 0)
+            if (info.isSystemApp()){
+                val uninstallMenuItem = popupMenu.menu.findItem(R.id.uninstall)
+                uninstallMenuItem.isVisible = false
+            }
+        }
+
         fun onAppClicked(app: UnlauncherApp) {
             launchApp(app.packageName, app.className, app.userSerial)
             home_fragment.transitionToStart()

app/src/main/java/com/sduduzog/slimlauncher/utils/Utils.kt

@@ -3,6 +3,7 @@ package com.sduduzog.slimlauncher.utils
 import android.app.Activity
 import android.content.Context
 import android.content.Intent
+import android.content.pm.ApplicationInfo
 import android.content.res.Configuration
 import android.graphics.Insets
 import android.graphics.Rect
@@ -93,4 +94,7 @@ fun createTitleAndSubtitleText(context: Context, title: CharSequence, subtitle:
     return spanBuilder
 }
 
-fun String.firstUppercase() = this.first().uppercase()
+fun String.firstUppercase() = this.first().uppercase()
+
+fun ApplicationInfo.isSystemApp(): Boolean = (this.flags and ApplicationInfo.FLAG_SYSTEM != 0) ||
+        (this.flags and ApplicationInfo.FLAG_UPDATED_SYSTEM_APP != 0)